Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 0.4.0 #1273

Merged
merged 1 commit into from
May 20, 2018
Merged

Release 0.4.0 #1273

merged 1 commit into from
May 20, 2018

Conversation

joshbruce
Copy link
Member

@joshbruce joshbruce commented May 18, 2018

Description

Publisher

  • $ npm version has been run.
  • Release notes in draft GitHub release are up to date
  • Release notes include which flavors and versions of Markdown are supported by this release
  • Committer checklist is complete.
  • Merge PR.
  • Publish GitHub release using master with correct version number.
  • $ npm publish has been run.
  • Create draft GitHub release to prepare next release.

Note: If merges to master occur after submitting this PR and before running $ npm pubish you should be able to

  1. pull from upstream/master (git pull upstream master) into the branch holding this version,
  2. run $ npm run build to regenerate the min file, and
  3. commit and push the updated changes.

Committer

In most cases, this should be someone different than the publisher.

  • Version in package.json has been updated (see PUBLISHING.md).
  • release does not change library.
  • CI is green (no forced merge required).

@joshbruce joshbruce requested review from UziTech and styfle May 18, 2018 21:15
Copy link
Member

@styfle styfle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It’s finally happening! 🎉

@styfle styfle added this to the 0.4.0 - No known defects milestone May 19, 2018
@styfle styfle merged commit 78db8fb into markedjs:master May 20, 2018
@styfle
Copy link
Member

styfle commented May 20, 2018

@joshbruce Can you publish today? Thanks 👍

@joshbruce joshbruce deleted the release-0.4.0 branch May 21, 2018 13:08
zhenalexfan pushed a commit to zhenalexfan/MarkdownHan that referenced this pull request Nov 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants