Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix inline code regex #1337

Merged
merged 2 commits into from
Sep 20, 2018
Merged

fix inline code regex #1337

merged 2 commits into from
Sep 20, 2018

Conversation

UziTech
Copy link
Member

@UziTech UziTech commented Sep 16, 2018 •
edited by styfle
Loading

Marked version: 0.5.0

Description

  • Fix inline code trimming

fixes #1218

Contributor

  • Test(s) exist to ensure functionality and minimize regression

Committer

In most cases, this should be a different person than the contributor.

  • Draft GitHub release notes have been updated.
  • CI is green (no forced merge required).
  • Merge PR

@styfle
Copy link
Member

styfle commented Sep 16, 2018

Which issue is this fixing?
Or is this just something you noticed recently?

@UziTech
Copy link
Member Author

UziTech commented Sep 16, 2018

The slack issue

styfle
styfle approved these changes Sep 16, 2018
View reviewed changes
Copy link
Member

@styfle styfle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@davisjam
Copy link
Contributor

davisjam commented Sep 16, 2018 •
edited
Loading

I'm not confident that this change will address the Slack issue. I will ponder it tomorrow.

@UziTech
Copy link
Member Author

UziTech commented Sep 16, 2018

When I tested this change the POC went from 9s to a few ms

@davisjam
Copy link
Contributor

@UziTech Acknowledged. I am thinking about whether variations will still lead to the problem.

@UziTech
Copy link
Member Author

UziTech commented Sep 17, 2018

I updated the regex to pass more of the code span spec. @davisjam check if the new regex is safe.

@UziTech UziTech mentioned this pull request Sep 18, 2018
Closed
@styfle styfle mentioned this pull request Sep 18, 2018
Merged
1 task
Feder1co5oave added a commit to Feder1co5oave/marktex that referenced this pull request Sep 18, 2018
@Feder1co5oave
add tests from markedjs#1307, markedjs#1327, and markedjs#1337
51e97fd
@UziTech
Copy link
Member Author

UziTech commented Sep 18, 2018

I rebased and fixed the merge conflicts after #1338

@davisjam
Copy link
Contributor

I have reviewed the regexes. LGTM.

@styfle styfle merged commit b891696 into markedjs:master Sep 20, 2018
@joshbruce
Copy link
Member

Releasing

@UziTech
Copy link
Member Author

UziTech commented Sep 23, 2018

@joshbruce I really think we should merge #1331 before a new release

@joshbruce
Copy link
Member

Oh. I thought it was already merged. Still good to go, yeah? (From 17 days ago, my bad.)

@UziTech
Copy link
Member Author

UziTech commented Sep 23, 2018

Yup should be good to go

@styfle styfle mentioned this pull request Sep 24, 2018
Merged
12 tasks
@UziTech UziTech deleted the code-trimmed branch February 19, 2019 20:12
@snyk-bot snyk-bot mentioned this pull request Aug 19, 2019
Open
This was referenced Aug 30, 2019
Open
Open
@snyk-bot snyk-bot mentioned this pull request Sep 24, 2019
Open
@snyk-bot snyk-bot mentioned this pull request Oct 26, 2019
Open
@balde-infidem balde-infidem mentioned this pull request Sep 11, 2024
Open
@P-Varshney08 P-Varshney08 mentioned this pull request Sep 11, 2024
Open
@restinpeaceinout restinpeaceinout mentioned this pull request Sep 12, 2024
Open
@basantMishra2956 basantMishra2956 mentioned this pull request Sep 12, 2024
Open
@prashanty0246 prashanty0246 mentioned this pull request Sep 12, 2024
Open
@P-Varshney08 P-Varshney08 mentioned this pull request Sep 13, 2024
Open
@FullBeardDev FullBeardDev mentioned this pull request Sep 13, 2024
Open
@basantMishra2956 basantMishra2956 mentioned this pull request Sep 13, 2024
Open
@IT21168222 IT21168222 mentioned this pull request Sep 13, 2024
Open
@P-Varshney08 P-Varshney08 mentioned this pull request Sep 14, 2024
Open
@basantMishra2956 basantMishra2956 mentioned this pull request Sep 14, 2024
Open
@FullBeardDev FullBeardDev mentioned this pull request Sep 14, 2024
Open
@prashanty0246 prashanty0246 mentioned this pull request Sep 14, 2024
Open
@P-Varshney08 P-Varshney08 mentioned this pull request Sep 15, 2024
Open
@FullBeardDev FullBeardDev mentioned this pull request Sep 15, 2024
Open
@basantMishra2956 basantMishra2956 mentioned this pull request Sep 15, 2024
Open
@P-Varshney08 P-Varshney08 mentioned this pull request Sep 16, 2024
Open
@basantMishra2956 basantMishra2956 mentioned this pull request Sep 17, 2024
Open
@FullBeardDev FullBeardDev mentioned this pull request Sep 17, 2024
Open
@anashope anashope mentioned this pull request Sep 17, 2024
Open
@basantMishra2956 basantMishra2956 mentioned this pull request Sep 17, 2024
Open
This was referenced Sep 18, 2024
Open
Open
@FullBeardDev FullBeardDev mentioned this pull request Sep 18, 2024
Open
@OATEF4313 OATEF4313 mentioned this pull request Sep 18, 2024
Open
@basantMishra2956 basantMishra2956 mentioned this pull request Sep 19, 2024
Open
@P-Varshney08 P-Varshney08 mentioned this pull request Sep 19, 2024
Open
@FullBeardDev FullBeardDev mentioned this pull request Sep 19, 2024
Open
@P-Varshney08 P-Varshney08 mentioned this pull request Sep 20, 2024
Open
@FullBeardDev FullBeardDev mentioned this pull request Sep 20, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@styfle styfle styfle approved these changes

@davisjam davisjam davisjam approved these changes

Assignees
No one assigned
Labels
category: code blocks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Code blocks with email-like text are no longer parsed as code
4 participants
@UziTech @styfle @davisjam @joshbruce