-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix builds: remove node v0.10 from travis matrix #1366
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this constitute a breaking change?
@UziTech That's a great question 🤔 I think we could say this PR itself is not breaking because it doesn't actually break compatibility with older versions of node, its just a change to CI. However, our next release that contains breaking changes (0.6.0) should mention that node v0.10 is no longer supported. It's a loop-hole but it will get CI green again and get the patch release out (0.5.2) |
Good candidate for release notes. |
@davisjam I will definitely add to release notes once you approve 😄 |
I couldn't find if we officially support any browser/versions though. I know we don't run automated tests in any browsers. So my best way to communicate v0.10 as a browser is IE. Thoughts on this one? |
Description
Fixes our failing builds.
Node v0.10 went End-of-Life two years ago which is why jasmine (our test framework) won't work anymore (looks like they dropped support awhile ago and just introduced breaking changes recently.
Related: jasmine/jasmine-npm#144
Contributor
Committer
In most cases, this should be a different person than the contributor.