Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New line after table #1439

Merged
merged 3 commits into from
Mar 12, 2019
Merged

New line after table #1439

merged 3 commits into from
Mar 12, 2019

Conversation

UziTech
Copy link
Member

@UziTech UziTech commented Mar 7, 2019

Marked version: master

Markdown flavor: GitHub Flavored Markdown

Description

Fixes new line after a table removing last |

Contributor

  • Test(s) exist to ensure functionality and minimize regression

Committer

In most cases, this should be a different person than the contributor.

  • Draft GitHub release notes have been updated.
  • CI is green (no forced merge required).
  • Merge PR

@styfle
Copy link
Member

styfle commented Mar 8, 2019

There are some merge conflicts

@UziTech
Copy link
Member Author

UziTech commented Mar 8, 2019

That is the issue with using a json file for all of the tests. Once one is merged all other PRs that add tests to that file will have a merge conflict.

@styfle
Copy link
Member

styfle commented Mar 8, 2019

And also json has to escape quotes and such 🙄

@styfle
Copy link
Member

styfle commented Mar 8, 2019

Is this use case in the spec?

@UziTech
Copy link
Member Author

UziTech commented Mar 8, 2019

Yes, our implementation was only wrong when there is an escaped pipe in the table

@UziTech UziTech requested review from davisjam and joshbruce March 9, 2019 17:37
This was referenced Mar 9, 2019
Copy link
Contributor

@davisjam davisjam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it works...This replaces a quadratic regex with a linear one so I am in favor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants