Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add favicon to docs #1710

Merged
merged 1 commit into from
Jun 17, 2020
Merged

add favicon to docs #1710

merged 1 commit into from
Jun 17, 2020

Conversation

UziTech
Copy link
Member

@UziTech UziTech commented Jun 16, 2020 •
edited by styfle
Loading

Description

Add favicon to docs

image

Contributor

  • Test(s) exist to ensure functionality and minimize regression (if no tests added, list tests covering this PR); or,
  • no tests required for this PR.
  • If submitting new feature, it has been documented in the appropriate places.

Committer

In most cases, this should be a different person than the contributor.

  • Draft GitHub release notes have been updated.
  • CI is green (no forced merge required).
  • Merge PR

@UziTech UziTech added the category: docs Documentation changes label Jun 16, 2020
@vercel
Copy link

vercel bot commented Jun 16, 2020 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/markedjs/markedjs/je2tby37q
✅ Preview: https://markedjs-git-fork-uzitech-favicon.markedjs.vercel.app

@UziTech UziTech requested review from davisjam, joshbruce and styfle June 17, 2020 15:10
styfle
styfle approved these changes Jun 17, 2020
View reviewed changes
Copy link
Member

@styfle styfle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

favicon

@styfle styfle merged commit 26cb01f into markedjs:master Jun 17, 2020
@UziTech UziTech deleted the favicon branch July 13, 2020 13:38
@UziTech UziTech mentioned this pull request Jul 13, 2020
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@styfle styfle styfle approved these changes

@davisjam davisjam Awaiting requested review from davisjam

@joshbruce joshbruce Awaiting requested review from joshbruce

Assignees
No one assigned
Labels
category: docs Documentation changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Website loading speed:
2 participants
@UziTech @styfle