Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature renderer #301

Closed
wants to merge 4 commits into from
Closed

Conversation

lepture
Copy link
Contributor

@lepture lepture commented Dec 4, 2013

I started this at commit: 0d27d58

Related issue: #129

At markedjs#129, it only contains block level renderers. This patch contains
both block level and span level renderers.
Since renderer feature can do many things, I removed highlight option
and headerPrefix option.

markedjs#129
Remove documentation on langPrefix.
Add documentation on renderer.
@chjj
Copy link
Member

chjj commented Dec 4, 2013

I actually just merged everything by hand. It wasn't that bad. Just curious, why was the async highlighting removed?

@chjj
Copy link
Member

chjj commented Dec 4, 2013

Closing. I added the async highlighting back because:

  1. We need it for backward compat.
  2. I fail to see how adding renderer impacts it at all.

@chjj chjj closed this Dec 4, 2013
@chjj
Copy link
Member

chjj commented Dec 4, 2013

Anyway, I've made a few changes. Everything is working well. Great work. :)

If you want to make anymore changes, I suggest pulling from upstream. Everything is there now.

@chjj
Copy link
Member

chjj commented Dec 4, 2013

Ah, okay, I see why you removed highlight for sync highlighting, but users will have to be expected to do the async highlighting by hand now. We should probably open another issue debating this whole thing. I really like the approach of removing options that are obsolete now, but highlight is a pretty core option by now. A lot of people would be confused.

@tvooo
Copy link

tvooo commented Dec 5, 2013

@chjj Would you mind creating a new version tag with this feature in it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants