-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IDs of headings with inline tokens (link, em, bold...) #456
Conversation
Is this still being looked at @chjj ? |
@F1LT3R definitely no. |
As in... it shouldn't be, or... it hasn't been? |
I meant marked is not being maintained any more |
Ah Ok. Thanks @Feder1co5oave. I've just been testing out your clean-segments commit and I think it's a great improvement. Is there something better NPM module for markdown that I should be using instead? |
I'm still with marked, but there exist some more modern and maintained parsers out there. I haven't tried any yet so I can't help you. |
Thanks |
Thanks @JCMais !! |
I'll try and provide some tests, I think this is still relevant, even if it covers some edge cases only. |
d6b7068
to
379c2c2
Compare
Added test cases. |
Getting two failing tests. Want to make sure they're because of some things fixed elsewhere before merging this in...if nothing else, they should be totally unrelated.
|
I confirm that they are related to something else, and they both should be solved by my two [commonmark] PRs. |
IDs of headings with inline tokens (link, em, bold...)
PR for #450
I hope it doesn't seem overkilling, I kept it as small as possible.
Comments are welcome. I'll be posting some tests, if I can manage to make them work.
Meanwhile I tested it with
and I got
which looks good to me.
Fixes #450, fixes #510