#588 Add option to allow json output instead of a string #589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This changes a lot and adds a lot of method calls. Is the overhead worth the benefit? |
|
I have no idea how to do differently. The rendering result was originally conceived in order to return a string. To return result in any formats, were invented such a decision. In addition this solution is extensible. Moreover, the method call not greatly affect the speed of execution. |
|
Look module markdown-bemjson, it based on forked marked. |
|
Closing due to merge conflicts, stale, missing tests, and beyond scope for the focus per #956. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.