Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Allow rendering user-defined progress-text in Pagination #80

Merged
merged 2 commits into from
Apr 22, 2024

Conversation

boredland
Copy link
Contributor

... so users preferring a different translation or something like "1/10" can do that.

... so users preferring a different translation or something like "1/10" can do that.
@boredland
Copy link
Contributor Author

boredland commented Mar 31, 2024

Word of warning: My development setup for this repo leaves room for improvement - not sure this works as it should. I never worked on a library bundling Astro components.

@boredland boredland changed the title ✨ Allow passing rendering user-defined texts to Pagination ✨ Allow rendering user-defined progres-text in Pagination Mar 31, 2024
@boredland boredland changed the title ✨ Allow rendering user-defined progres-text in Pagination ✨ Allow rendering user-defined progress-text in Pagination Apr 10, 2024
@markteekman
Copy link
Owner

Hey @boredland, thanks for submitting this pull request! I've been quite occupied lately but I'll try and take a look at it soon 😊 Thanks for your patience!

Copy link
Owner

@markteekman markteekman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great addition @boredland! Only one small change 🙂

Pagination.astro Outdated Show resolved Hide resolved
Copy link
Owner

@markteekman markteekman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just committed the change myself so this can be merged.

@markteekman markteekman merged commit 29dab24 into markteekman:main Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants