-
Notifications
You must be signed in to change notification settings - Fork 725
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#1157 add an issue template with a request for Plunkr repro steps #1159
#1157 add an issue template with a request for Plunkr repro steps #1159
Conversation
Thanks @RichardBradley for contributing to marmelab open-source projects! |
Awesome, thanks! |
@RichardBradley your template does not seems to work anymore with latest master code :( Probably because http://rawgit.com/marmelab/ng-admin/master/build/ng-admin.min.js does not exists |
Yes, the published built files were removed recently at 4d586e6 I'm not sure what the Plunkr demo should use instead? Are they now published on npm or similar? |
Not sure myself. The updated documentation still refer to the build file. using webpack I actually built it myself. |
@Phocea: no, built files won't be committed on this repository anymore. However, we can use unpkg to get final files: https://unpkg.com/ng-admin/build/ng-admin.min.js (as they are built during npm publishing). We need to update the PlunkR and to indicate it points to last published version. |
@jpetitcolas great. This is indeed working U(http://plnkr.co/edit/JkgrLFgvz7jP6Ee6w0m9). I dont have write access to the original plunkr though. @RichardBradley can you make the update please ? |
I tried, but I don't have write permissions to the "qrw9Y8rfUUmHM4rOJo1q" plunkr either, it belongs to http://plnkr.co/users/sam2x https://github.com/sam2x It might be better to update the issue template to point to a plunkr under the control of a regular contributor? |
First draft of an issue template re #1157