Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1157 add an issue template with a request for Plunkr repro steps #1159

Merged
merged 1 commit into from
Aug 10, 2016

Conversation

RichardBradley
Copy link
Contributor

First draft of an issue template re #1157

@fzaninotto fzaninotto merged commit 1dc0cac into marmelab:master Aug 10, 2016
@marmelab-bot
Copy link
Contributor

Thanks @RichardBradley for contributing to marmelab open-source projects!
As a sign of our gratitude, you can publish an image to advertise your brand on the marmelab website for a whole day.
Head to this page to submit your image. It will appear on Zero Dollar Homepage, powered by blockchain technology.

@fzaninotto
Copy link
Member

Awesome, thanks!

@Phocea
Copy link
Contributor

Phocea commented Sep 27, 2016

@RichardBradley your template does not seems to work anymore with latest master code :(

Probably because http://rawgit.com/marmelab/ng-admin/master/build/ng-admin.min.js does not exists

@RichardBradley
Copy link
Contributor Author

Yes, the published built files were removed recently at 4d586e6

I'm not sure what the Plunkr demo should use instead? Are they now published on npm or similar?
Maybe http://marmelab.com/ng-admin-demo/build/ng-admin.min.js ?

@Phocea
Copy link
Contributor

Phocea commented Sep 28, 2016

Not sure myself. The updated documentation still refer to the build file. using webpack I actually built it myself.
The problem with the ng-admin-demo is that we can never be sure of it's version. At the moment it is not pointing to the master code or the latest published version (the <div ui-view> has not been updated with necessary changes)
@jpetitcolas are those files still planned to be built and published on this repo?

@jpetitcolas
Copy link
Contributor

@Phocea: no, built files won't be committed on this repository anymore. However, we can use unpkg to get final files: https://unpkg.com/ng-admin/build/ng-admin.min.js (as they are built during npm publishing). We need to update the PlunkR and to indicate it points to last published version.

@Phocea
Copy link
Contributor

Phocea commented Sep 28, 2016

@jpetitcolas great. This is indeed working U(http://plnkr.co/edit/JkgrLFgvz7jP6Ee6w0m9). I dont have write access to the original plunkr though. @RichardBradley can you make the update please ?

@RichardBradley
Copy link
Contributor Author

I tried, but I don't have write permissions to the "qrw9Y8rfUUmHM4rOJo1q" plunkr either, it belongs to http://plnkr.co/users/sam2x https://github.com/sam2x

It might be better to update the issue template to point to a plunkr under the control of a regular contributor?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants