Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFR] Update select choices whenever entry changes #1195

Merged
merged 2 commits into from
Sep 19, 2016
Merged

Conversation

jpetitcolas
Copy link
Contributor

@jpetitcolas jpetitcolas commented Sep 19, 2016

Fixes #1193.

  • Update available choices on maChoicesField when model changes
  • Update selected value when available choices are changed

@jpetitcolas
Copy link
Contributor Author

Switching to RFR:
anim

@jpetitcolas jpetitcolas changed the title [WIP] Update select choices whenever entry changes [RFR] Update select choices whenever entry changes Sep 19, 2016
@@ -243,7 +243,7 @@ make test
**Tip:** If you are working on Karma tests, you can prevent from relaunching the whole process by disabling single-run:

```
KARMA_SINGLE_RUN=false ./node_modules/.bin/grunt karma:unit
./node_modules/.bin/karma start src/javascripts/test/karma.conf.js
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just updating the outdated command.

@jpetitcolas jpetitcolas added this to the 1.0 milestone Sep 19, 2016
@fzaninotto fzaninotto merged commit 12cc373 into master Sep 19, 2016
@fzaninotto fzaninotto deleted the subselect branch September 19, 2016 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants