[WIP] Better http error handling #1257
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Removed extra space after the parenthesis - Used camelCase for the methods name
typo/grammar
Fix display of Http Error Service link
Refactor notification.log(text, { addnCls: 'humane-flatty-error' }) into seperate method
**## javascript :)
Fix typo Fix call to displayError (allowing patch of displayError method in a decorator)
commit test to see if e2e tests are now passing!
Rebase from ng-admin Mastser
Test for Http Error Service
Add correct parameter in method 404 call. Add break in each case block
Add tests on displayError being called
Better http error handling
|
@jpetitcolas There is still an issue with protractor or SauceLabs. Can you take a look? |
|
@Phocea the build fails, but it seems to be because of a problem in your code rather than a build artefact. Can you take a look? |
|
Tests should be fixed now, but we still need to check new feature. I quickly copy/pasted README sample, but it doesn't boot the application anymore. Back to WIP, but we should not be too far. :) |
jpetitcolas
changed the title
jpetitcolas
reviewed
Dec 5, 2016
|
|
||
| httpErrorService.$inject = ['$state', '$translate', 'notification']; | ||
|
|
||
| export default httpErrorService; | ||
| export default { $get: httpErrorService }; |
There was a problem hiding this comment.
@Phocea: this is a provider, hence we need a $get method. :)
Merged
|
Replaced by #1257 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Phocea Following #1253