Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RFR] Use field label for embedded list add button #1281

Merged
merged 1 commit into from
Jan 5, 2017
Merged

[RFR] Use field label for embedded list add button #1281

merged 1 commit into from
Jan 5, 2017

Conversation

jpetitcolas
Copy link
Contributor

Fixes #1114, #1187.

@jpetitcolas jpetitcolas added this to the 1.0 milestone Dec 21, 2016
Phocea
Phocea reviewed Dec 21, 2016
View reviewed changes
Copy link
Contributor

@Phocea Phocea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do you use the lowercase version of the label ?

@jpetitcolas
Copy link
Contributor Author

For a better looking button. I prefer "Add a link" to Add a Link". But I'm not a native English speaker. Perhaps standard form would be better?

@Phocea
Copy link
Contributor

Phocea commented Dec 22, 2016

Isn't it going to be "add a link" if all lowercase though ?
Just let whatever was set in the label decide no ?

Phocea
Phocea approved these changes Dec 22, 2016
View reviewed changes
Copy link
Contributor

@Phocea Phocea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

after discussion, good for me

@fzaninotto fzaninotto merged commit 7b5d5b6 into master Jan 5, 2017
@fzaninotto fzaninotto deleted the embedded_list_button branch January 5, 2017 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Phocea Phocea Phocea approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.0
Development

Successfully merging this pull request may close these issues.
3 participants
@jpetitcolas @Phocea @fzaninotto