Makefile: Fix generating source-map with webpack #1307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The command is slightly different to really get source maps for the `ng-admin.min.js` and `ng-admin.min.css` files.
|
@Kmaschta can we merge this. Creating the sourcemap can take a bit of time but its indeed useful for debugging |
|
I merge it, but I would love a double check from @fzaninotto |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ATM there are no sourcemaps available, what is quite a pain to debug. It seems as if they were intended to exist in the first place.
The command in the Makefile is slightly different to really get sourcemaps for the
ng-admin.min.jsandng-admin.min.cssfiles.