Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFR] Fix DateField watches #1318

Merged
merged 1 commit into from
Mar 8, 2017
Merged

[RFR] Fix DateField watches #1318

merged 1 commit into from
Mar 8, 2017

Conversation

Kmaschta
Copy link
Contributor

@Kmaschta Kmaschta commented Mar 8, 2017

Fix #1271
Fix #1305
Supersede #1317

@Kmaschta Kmaschta force-pushed the datefield-watches branch from baff46d to ad7287b Compare March 8, 2017 15:02
@Kmaschta Kmaschta changed the title [WIP] Fix DateField watches [RFR] Fix DateField watches Mar 8, 2017
@floo51 floo51 merged commit 6dc31ae into master Mar 8, 2017
@floo51 floo51 deleted the datefield-watches branch March 8, 2017 15:19
@matheo
Copy link
Contributor

matheo commented Mar 14, 2017

The persisting but minor issue is that the date selector also modify the original value I guess, because when you select a date it works fine, but if you open again, it show the previous date as selected. Maybe that plugin is having the timezone difference too.
This date-time stuff is quite sensible, Javascript itself needed more clarity handling these values.

@Kmaschta
Copy link
Contributor Author

I agree.
To be sure to sully understand you, can you open/complate an issue about that, with a simple example to reproduce it ?
Thanks

@matheo
Copy link
Contributor

matheo commented Mar 15, 2017

I'm short of time right now,
and I guess that timezone issues will arise everywhere due to the multiple String <-> Date conversion on javascript. First on the DateField plugin, then later in the DatePicker. I'm experiencing issues with a Date filter too. So, this timezone stuff is all around.

@thanhbuiea
Copy link

thanhbuiea commented Nov 29, 2017

hi @Kmaschta , we still have problem with Infinite Loop due to DateField watches. I'm now on the latest version. This fix seems not to be able to resolve the bug totally. Could you please double check on it? If you need any clue or log, please let me know. Thanks. Hope to see you reply on this soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants