[RFR] Infinite scroll: avoid to load multiple time at the same time #1322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Kmaschta
changed the title
Kmaschta
force-pushed
the
fix-infinite-scrolling
branch
from
9b0cec7
to
d809f5a
Compare
djhi
requested changes
Mar 15, 2017
package.json
Outdated
| @@ -52,6 +52,7 @@ | |||
| "babel-preset-stage-2": "^6.13.0", | |||
| "chai": "^3.3.0", | |||
| "css-loader": "^0.25.0", | |||
| "diff": "^3.2.0", | |||
There was a problem hiding this comment.
Even in dev deps ?
My opinion is:
~for client projects^is OK for open-source
floo51
suggested changes
Mar 16, 2017
| @@ -1,10 +1,14 @@ | |||
| import angular from 'angular'; | |||
|
|
|||
| export default function maDatagridInfinitePagination($window, $document) { | |||
| const isDownScrolling = wheelEvent => { | |||
| }; | ||
|
|
||
| // Trigger the scroll at least once | ||
| // In this case, we'll avoid that a pagination of a few element (< 10) |
There was a problem hiding this comment.
Hard to understand, can you rephrase this or have a longer explanation ?
floo51
approved these changes
Mar 16, 2017
djhi
approved these changes
Mar 16, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #681
Supersedes #1068
wheelevent