Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RFR] Use http error service handlers inside view events #1339

Merged
merged 2 commits into from
Apr 27, 2017
Merged

[RFR] Use http error service handlers inside view events #1339

merged 2 commits into from
Apr 27, 2017

Conversation

floo51
Copy link
Contributor

@floo51 floo51 commented Apr 25, 2017

The HttpErrorService decorator wasn't working on view like on "Submit changes".

It should now work.

Still untested, need some more work.

@Kmaschta
Copy link
Contributor

Kmaschta commented Apr 26, 2017 •
edited
Loading

I'm OK with this PR.
@Phocea Do you have any observation?

@floo51 floo51 force-pushed the fix_httperrorservice_decorator branch from 39b4ce9 to 1336e2d Compare April 26, 2017 15:35
@floo51 floo51 changed the title [WIP] Use http error service handlers inside view events [RFR] Use http error service handlers inside view events Apr 26, 2017
Kmaschta
Kmaschta approved these changes Apr 26, 2017
View reviewed changes
Copy link
Contributor

@Kmaschta Kmaschta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be tested on a real project.

@floo51
Copy link
Contributor Author

floo51 commented Apr 27, 2017

Just tested, works as expected

Phocea
Phocea approved these changes Apr 27, 2017
View reviewed changes
Copy link
Contributor

@Phocea Phocea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay, was attending a workshop!
This unify the code very well, good catch.

@fzaninotto fzaninotto merged commit 186d98f into master Apr 27, 2017
@fzaninotto fzaninotto deleted the fix_httperrorservice_decorator branch April 27, 2017 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fzaninotto fzaninotto fzaninotto approved these changes

@Phocea Phocea Phocea approved these changes

@Kmaschta Kmaschta Kmaschta approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@floo51 @Kmaschta @fzaninotto @Phocea