-
Notifications
You must be signed in to change notification settings - Fork 725
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] integrate export-to-csv directive into ng-admin #316
Conversation
Hi @ThieryMichel, I'm trying to test your branch, and the following error is occurring:
Am I missing something? |
@endel No it was a mistake on my part. Corrected it. |
case 'template': | ||
map[order] = {name: attr, type: 'Field'}; | ||
break; | ||
case 'Reference': |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
must be reference
with a lowercase c
. Same for referenced_list
(refs #307).
Very nice. For the configurability, I suggest that you use a smart setter comparable to // by default, the csv export should use the field list from the list view
myEntity.listView()
.exportFields(myEntity.listView.fields())
// developers can customize it with a custom field list
myEntity.listView()
.exportFields([
nga.field('foo'),
nga.field('bar')
]) |
0499939
to
354abac
Compare
Bump |
c2b32ee
to
223cb15
Compare
Hi @ThieryMichel, is there any commit to solve the problem pointed out by @endel on February 19? Thanks in advance |
Just fixed it. |
[WIP] integrate export-to-csv directive into ng-admin
Thanks for this great feature! |
feature: #230