[BC Break][RFR] Specialize Configuration Field Classes #327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fzaninotto
force-pushed
the
factory_3
branch
from
f47822d
to
07e1c04
Compare
fzaninotto
changed the title
fzaninotto
changed the title
* Speeds up datagrid rendering (less scopes) * Removes need for referenced_list hack
fzaninotto
force-pushed
the
factory_3
branch
from
6e965dd
to
c9fcfec
Compare
fzaninotto
changed the title
|
Switching to RFR |
jpetitcolas
added a commit
that referenced
this pull request
Mar 2, 2015
[BC Break][RFR] Specialize Configuration Field Classes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This finishes the Factory refactoring by using specialized configuration field classes under the hood.
new Field().type('date')doesn't work anymore after this patch is merged, it breaks compatibility with 0.5.Follows #325 and refs #294