Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RFR] Backward compatibility #356

Merged
merged 5 commits into from
Mar 12, 2015
Merged

[RFR] Backward compatibility #356

merged 5 commits into from
Mar 12, 2015

Conversation

jpetitcolas
Copy link
Contributor

  • Fix build process (missing configuration part)
  • Add BC proxy methods to ConfigurationProvider
  • Test it on real-world project
  • Update README and UPGRADE files

@fzaninotto
Copy link
Member

Don't forget the README and UPGRADE files

jpetitcolas
jpetitcolas reviewed Mar 11, 2015
View reviewed changes
src/javascripts/ng-admin/es6/lib/Factory.js
@@ -46,6 +46,10 @@ class Factory {
this._fieldTypes[name] = constructor;
}

getFieldConstructor(name) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added to ease inheritance for custom types.

@jpetitcolas jpetitcolas changed the title [WIP] Backward compatibility [RFR] Backward compatibility Mar 11, 2015
@jpetitcolas
Copy link
Contributor Author

Switching to RFR. Tests pass locally.

fzaninotto
fzaninotto reviewed Mar 12, 2015
View reviewed changes
UPGRADE-0.7.md

``` diff
- app.config(function (NgAdminConfigurationProvider, RestangularProvider) {
+ app.config(function (AdminDescription, NgAdminProvider, RestangularProvider) {
+ app.config(function (AdminDescription, NgAdminConfigurationProvider, RestangularProvider) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove AdminDescription

@jpetitcolas
Copy link
Contributor Author

Files updated. But tests are still failing on Travis only. Should we merge it?

fzaninotto added a commit that referenced this pull request Mar 12, 2015
@fzaninotto
Merge pull request #356 from marmelab/backward_compatibility
ca7af35 
[RFR] Backward compatibility
@fzaninotto fzaninotto merged commit ca7af35 into master Mar 12, 2015
@fzaninotto fzaninotto deleted the backward_compatibility branch March 12, 2015 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jpetitcolas @fzaninotto