Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFR] Improve error handling #399

Merged
merged 1 commit into from
Apr 14, 2015
Merged

[RFR] Improve error handling #399

merged 1 commit into from
Apr 14, 2015

Conversation

fzaninotto
Copy link
Member

  • Add a 404 Not found page
  • Route unrecognized URLs to 404 page
  • Throw errors triggered in a resolve() function in the routing (they were silenced before)
  • Add a hidden cat

image

- Add a 404 Not found page
- Route unrecognized URLs to 404 page
- Throw errors triggered in a resolve() function in the routing (they
  were silenced before)
- Add a hidden cat
</div>

<pre class="ascii col-lg-offset-4 col-lg-4 col-md-offset-3 col-md-6 col-sm-offset-2 col-sm-8 col-cs-offset-1 col-xs-10">

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Poor kitten ...

alexisjanvier added a commit that referenced this pull request Apr 14, 2015
[RFR] Improve error handling
@alexisjanvier alexisjanvier merged commit 853dcb0 into master Apr 14, 2015
@alexisjanvier alexisjanvier deleted the 404-page branch April 14, 2015 21:25
@fzaninotto fzaninotto mentioned this pull request Apr 14, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants