Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFR][BC-BREAK] Remove referencedView created by code for ReferenceField #429

Merged
merged 5 commits into from
May 15, 2015

Conversation

jeromemacias
Copy link
Contributor

  • Remove creation of ListView in ReferenceField
  • Fix sort attributes for ma-datagrid directive
  • Fix tests
  • Add note about upgrade and BC-Break

@jeromemacias jeromemacias changed the title [WIP][BC-BREAK] Remove referencedView created by code for ReferenceField and fix sort parameter ma-datagrid directive attribute [RFR][BC-BREAK] Remove referencedView created by code for ReferenceField May 12, 2015
@jeromemacias
Copy link
Contributor Author

Tests are OK (see 3rd commit).


## View and Entity URL customization

Arguments for the anonymous function of the entity url customisation was changed.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/was/were

@fzaninotto
Copy link
Member

I'm OK for merge, but I'd like to know which PR should be merged first, yours or @manuquentin's?

@jeromemacias
Copy link
Contributor Author

As we discuss with @manuquentin, mine should be merged first, I let him confirm.

manuquentin added a commit that referenced this pull request May 15, 2015
[RFR][BC-BREAK] Remove referencedView created by code for ReferenceField
@manuquentin manuquentin merged commit 08ea55d into master May 15, 2015
@manuquentin manuquentin deleted the remove_referenced_view branch May 15, 2015 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants