-
Notifications
You must be signed in to change notification settings - Fork 726
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RFR] Boost Angular app performance #433
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Performance boost is slightly visible in demo app, locally on my laptop. |
Test are OK (see first commit build status). |
jeromemacias
force-pushed
the
boost_angular_performance
branch
from
May 13, 2015 08:32
f9938f8
to
db571d0
Compare
@@ -62,7 +62,8 @@ define(function (require) { | |||
factory.constant('AdminDescription', new AdminDescription()); | |||
|
|||
var ngadmin = angular.module('ng-admin', ['main', 'crud', 'AdminDescriptionModule']); | |||
ngadmin.config(function(NgAdminConfigurationProvider, AdminDescription) { | |||
ngadmin.config(['NgAdminConfigurationProvider', 'AdminDescription', '$compileProvider', function(NgAdminConfigurationProvider, AdminDescription, $compileProvider) { | |||
$compileProvider.debugInfoEnabled(false); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can it be configurable ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
jeromemacias
changed the title
[RFR] Boost Angular performance by disable debug and add ng-strict-di in demo app
[WIP] Boost Angular performance by disable debug and add ng-strict-di in demo app
May 13, 2015
jeromemacias
changed the title
[WIP] Boost Angular performance by disable debug and add ng-strict-di in demo app
[WIP] Boost Angular app performance
May 13, 2015
jeromemacias
changed the title
[WIP] Boost Angular app performance
[RFR] Boost Angular app performance
May 13, 2015
manuquentin
added a commit
that referenced
this pull request
May 13, 2015
[RFR] Boost Angular app performance
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #379
ng-strict-di
in demo app