Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFR] Boost Angular app performance #433

Merged
merged 3 commits into from
May 13, 2015
Merged

Conversation

jeromemacias
Copy link
Contributor

Fix #379

  • Boost Angular app performance by adding possibility to disable debug
  • Add ng-strict-di in demo app
  • Update documentation

@jeromemacias
Copy link
Contributor Author

Performance boost is slightly visible in demo app, locally on my laptop.

@jeromemacias
Copy link
Contributor Author

Test are OK (see first commit build status).

@jeromemacias jeromemacias force-pushed the boost_angular_performance branch from f9938f8 to db571d0 Compare May 13, 2015 08:32
@@ -62,7 +62,8 @@ define(function (require) {
factory.constant('AdminDescription', new AdminDescription());

var ngadmin = angular.module('ng-admin', ['main', 'crud', 'AdminDescriptionModule']);
ngadmin.config(function(NgAdminConfigurationProvider, AdminDescription) {
ngadmin.config(['NgAdminConfigurationProvider', 'AdminDescription', '$compileProvider', function(NgAdminConfigurationProvider, AdminDescription, $compileProvider) {
$compileProvider.debugInfoEnabled(false);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can it be configurable ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@jeromemacias jeromemacias changed the title [RFR] Boost Angular performance by disable debug and add ng-strict-di in demo app [WIP] Boost Angular performance by disable debug and add ng-strict-di in demo app May 13, 2015
@jeromemacias jeromemacias changed the title [WIP] Boost Angular performance by disable debug and add ng-strict-di in demo app [WIP] Boost Angular app performance May 13, 2015
@jeromemacias jeromemacias changed the title [WIP] Boost Angular app performance [RFR] Boost Angular app performance May 13, 2015
manuquentin added a commit that referenced this pull request May 13, 2015
@manuquentin manuquentin merged commit 33379fd into master May 13, 2015
@manuquentin manuquentin deleted the boost_angular_performance branch May 13, 2015 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Boost perf by disabling debug, but don't break tests
2 participants