[RFR] isDetailView doesn't work on refernced_list entity id-field #560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vasiakorobkin
changed the title
| @@ -133,7 +133,8 @@ | |||
| .targetReferenceField('post_id') | |||
| .targetFields([ | |||
| nga.field('created_at').label('Posted'), | |||
| nga.field('body').label('Comment') | |||
| nga.field('body').label('Comment'), | |||
| nga.field('id').isDetailLink(true) | |||
There was a problem hiding this comment.
Can you just move the id at the beginning of the table? That's more conventional! :)
|
Good for me. 👍 Can you rebase on master, as tests have been fixed yesterday to ensure everything is correct? |
|
Should fix #569. |
vasiakorobkin
force-pushed
the
go_to_detail_state_params_override
branch
from
9489aca to
3fefac8
Compare
|
Id field moved to the begining of the table. Branch was rebased. |
|
Your PR is still red. I don't think that's an issue with your PR. Looking at it. |
jpetitcolas
added a commit
that referenced
this pull request
Jul 24, 2015
…override [RFR] isDetailView doesn't work on refernced_list entity id-field
|
Tests are correctly passing on master. Thanks for your help! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is absolutely analogous to #537
This time isDetailLink() applied to
referenced_listentity doesn't work because of state parameter override.I've created a e2e-test to demonstrate it. Test fails on your master branch, and passes on my commit.