Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFR] Expose field constructors to avoid Webpack/Babel fuss #653

Merged
merged 1 commit into from
Sep 2, 2015

Conversation

fzaninotto
Copy link
Member

It becomes possible to recuperate a field constructor without installing the admin-config module:

var NumberField = nga.getFieldConstructor('number');

// now create a new class extending NumberField
function AmountField(name) {
  NumberField.call(this, name)
}
AmountField.prototype = new NumberField();
AmountField.prototype.constructor = AmountField;
// or something like that

jpetitcolas added a commit that referenced this pull request Sep 2, 2015
[RFR] Expose field constructors to avoid Webpack/Babel fuss
@jpetitcolas jpetitcolas merged commit 4e0c502 into master Sep 2, 2015
@jpetitcolas jpetitcolas deleted the getFieldConstructor branch September 2, 2015 16:46
@armellarcier
Copy link
Contributor

This is pretty cool! Thanks!

@manuelnaranjo
Copy link

pretty cool feature!

@armellarcier
Copy link
Contributor

Thanks guys! Your test/build workflow is really worth the fuss though!
Learned a lot from it! I moved to "vanilla" angular material because of the
apparent lack of Rest provider access since then. There is something
exciting there too!
Cheers!
Le ven. 4 sept. 2015 à 21:03, Manuel Francisco Naranjo <
notifications@github.com> a écrit :

pretty cool feature!


Reply to this email directly or view it on GitHub
#653 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants