[RFR] Required boolean fields use a checkbox for edition instad of a dropdown #707
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
djhi
commented
Sep 25, 2015
djhi
commented
- Added conditional display of choices or checkbox
- Updated example so that tag.published is a required boolean in edition
- Updated doc
- Updated chai to version 3 to have a working match method
djhi
changed the title
djhi
changed the title
| @@ -1,6 +1,11 @@ | |||
| module.exports = { | |||
| getReadWidget: () => '<ma-boolean-column value="::entry.values[field.name()]"></ma-boolean-column>', | |||
| getLinkWidget: () => '<a ng-click="gotoDetail()">' + module.exports.getReadWidget() + '</a>', | |||
| getReadWidget: () => '<ma-boolean-column value="::field.getLabelForChoice(entry.values[field.name()], entry)"></ma-boolean-column>', | |||
There was a problem hiding this comment.
I don't understand that change. Could you elaborate?
djhi
force-pushed
the
required_boolean
branch
from
bdb29e7
to
03f46fb
Compare
|
Needs rebase |
|
Good to merge once rebased |
- [x] Added conditional display of choices or checkbox - [x] Updated example so that tag.published is a required boolean in edition - [x] Updated doc - [x] Updated chai to version 3 to have a working match method
- [x] Reverted changes on BooleanFieldView.getReadWidget - [x] Fixed display on directive boolean-column
djhi
force-pushed
the
required_boolean
branch
from
442bbd9
to
c2abaf7
Compare
|
rebased |
fzaninotto
added a commit
that referenced
this pull request
Sep 30, 2015
[RFR] Required boolean fields use a checkbox for edition instad of a dropdown
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.