[RFR] Fix invalid reference to entry in datagrid header #708
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't understand this PR. What is invalid? |
|
|
|
And that was causing errors in the example app on the tags list view |
|
Ah, you're right. But in that case, I suggest we keep the call, without passing |
|
Ok but shouldn't we document that case ? |
- [x] Don't specify `entry` or headers - [x] Fix blog example to check for entry before using it in getCssClasses for tag published - [x] Updated doc
fzaninotto
added a commit
that referenced
this pull request
Sep 29, 2015
[RFR] Fix invalid reference to entry in datagrid header
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
entryor headers