[RFR] Upgrade Angular from 1.3 to 1.4 #945
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
alexisjanvier
commented
Feb 29, 2016
alexisjanvier
commented
- Upgrade to 1.4
- Fix test-unit and test-e2e
- Test with Posters Galore
- Upgrade readme file
- Deep manual testing
angular-mock, jasmine and protractor also
|
I suggest we merge once you get Angular 1.4 compatibility. Also, please be aware of the links in #567. |
|
I'm surprised that you don't need to update select2 |
|
@fzaninotto I had to update select2 (ui-select) when I updated to angular 1.5. This second update seems more problematic. |
alexisjanvier
changed the title
alexisjanvier
changed the title
alexisjanvier
changed the title
alexisjanvier
changed the title
fzaninotto
added a commit
that referenced
this pull request
Mar 1, 2016
[RFR] Upgrade Angular from 1.3 to 1.4
This was referenced Mar 1, 2016
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.