Applied review

marmelab · Sep 22, 2022 · 6f80a9f · 6f80a9f
1 parent 94836c1
commit 6f80a9f
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 21 deletions.
diff --git a/docs/Inputs.md b/docs/Inputs.md
@@ -510,7 +510,7 @@ import { FormDataConsumer } from 'react-admin';
 
  const PostEdit = () => (
      <Edit>
-         <SimpleForm>
+         <SimpleForm shouldUnregister>
              <BooleanInput source="hasEmail" />
              <FormDataConsumer>
                  {({ formData, ...rest }) => formData.hasEmail &&
@@ -522,25 +522,7 @@ import { FormDataConsumer } from 'react-admin';
  );
 ```
 
-**Important**: By default `react-hook-form` submits values of unmounted input components, so if you don't want this behaivour you can set `shouldUnregister` prop to `true` in the form
-
-```diff
-import { FormDataConsumer } from 'react-admin';
-
- const PostEdit = () => (
-     <Edit>
--        <SimpleForm>
-+        <SimpleForm shouldUnregister>
-             <BooleanInput source="hasEmail" />
-             <FormDataConsumer>
-                 {({ formData, ...rest }) => formData.hasEmail &&
-                      <TextInput source="email" {...rest} />
-                 }
-             </FormDataConsumer>
-         </SimpleForm>
-     </Edit>
- );
-```
+**Important**: By default `react-hook-form` submits values of unmounted input components, to prevent this from happen in the above example, `shouldUnregister` prop was set to `true` in the `<SimpleForm>`
 
 ## Overriding The Input Variant
 

diff --git a/docs/ListBase.md b/docs/ListBase.md
@@ -63,4 +63,4 @@ The `<ListBase>` component accepts the same props as [`useListController`](./use
 * [`resource`](./List.md#resource)
 * [`sort`](./List.md#sort-default-sort-field--order)
 
-These are a subset of the props accepted by `<List>` - only the props that change data fetching, and not the props related to the user interface.
+These are a subset of the props accepted by `<List>` - only the props that change data fetching, and not the props related to the user interface.