Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade material-ui/icons to 2.x #2189

Closed
swrobel opened this issue Aug 20, 2018 · 5 comments
Closed

Upgrade material-ui/icons to 2.x #2189

swrobel opened this issue Aug 20, 2018 · 5 comments

Comments

@swrobel
Copy link
Contributor

swrobel commented Aug 20, 2018

@material-ui/icons has been releasing 2.x versions for ~2 months. There are breaking changes that may or may not affect RA. I'm hoping someone familiar with the project will easily be able to see whether or not they affect it.

The issue is that @material-ui/core 1.5.1 depends on babel 7.0.0-rc1, which changes the structure of @babel/runtime. The changes to @material-ui/icons that are compatible with this change in babel are in the 2.x versions.

I suppose an alternative solution would be to try to get @material-ui to backport these changes to the 1.x branch of /icons.

@fzaninotto
Copy link
Member

To me, that means that @material-ui/core 1.5.1 is a breaking change which doesn't respect semver...

@fzaninotto
Copy link
Member

Confirmed: that's a material-ui bug, they're addressing it.

mui/material-ui#12621

@fzaninotto
Copy link
Member

@material-ui/icons@1.1.1 was just published, it should fix the problem? Feel free to reopen if it's not solved.

@maicWorkGithub
Copy link

maicWorkGithub commented Jan 14, 2019

Any plan upgrade to material-ui to 3.x?

Issue. I know this is not RA's problem, but keep up with latest version will be better.

Thanks, RA helps me a lot.

@fzaninotto
Copy link
Member

@maicWorkGithub see discussion in #2399

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants