Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Icons] Update Material Design Icons #12016

Merged
merged 6 commits into from
Jul 1, 2018
Merged

[Icons] Update Material Design Icons #12016

merged 6 commits into from
Jul 1, 2018

Conversation

mbrookes
Copy link
Member

@mbrookes mbrookes commented Jun 29, 2018 •
edited
Loading

Closes #11883
Closes #11810

capture d ecran 2018-07-01 a 23 36 46

Breaking change

This pull request allows React users to take advantage of the icons revamp the Material Design Team has been recently released. Some icons have been removed, ~150 new icons have been added, and some icons have been renamed. There are also currently some issues with the size of certain icons. It's a breaking change.

v1 icons not included in v2:

  • ContentCopy
  • ContentCut
  • ContentPaste
  • DoNotDisturb
  • DoNotDisturbAlt
  • DoNotDisturbOff
  • DoNotDisturbOn
  • FileDownload (available in @material-ui/docs/svgIcons)
  • FileUpload
  • InfoOutline
  • LabelOutline
  • LightbulbOutline (available in @material-ui/docs/svgIcons)
  • LockOutline
  • ModeEdit
  • SentimentNeutral
  • SimCardAlert
  • SystemUpdateAlt

v1 icons not included in v2 due to incorrect size (Use other styles):

  • Domain (filled)
  • Settings (filled)
  • Weekend (filled)

v2 icons not included due to incorrect size (Use other styles except for StarRate - use Star / StarBorder / StarHalf):

  • CastForEducation (filled)
  • Domain (filled)
  • PlayCircleFilledWhite (filled)
  • StarRate (filled)
  • StarRateOutlined
  • StarRateRound
  • StarRateTwotone
  • StarRateSharp

@oliviertassinari

This comment has been minimized.

Sign in to view
@oliviertassinari
Copy link
Member

oliviertassinari commented Jun 30, 2018 •
edited
Loading

I think that we can use svgo to clean the sources.
I'm wondering. Why bumping a major version? How is this a breaking change?

@mbrookes
Copy link
Member Author

mbrookes commented Jun 30, 2018 •
edited
Loading

How is this a breaking change?

Because some icons no longer exists, others, the name has changed.

@oliviertassinari oliviertassinari self-requested a review June 30, 2018 21:44
@oliviertassinari oliviertassinari added component: Icon The React component. new feature New feature or request labels Jun 30, 2018
@mbrookes mbrookes merged commit aa8ee1a into mui:master Jul 1, 2018
@oliviertassinari
Copy link
Member

@mbrookes What about doing a beta release for the icons?

acroyear pushed a commit to acroyear/material-ui that referenced this pull request Jul 14, 2018
@mbrookes
[Icons] Update Material Design Icons (mui#12016)
817d181 
* [Icons] Update Material Design Icons

* Use svgo

* remove extra <g></g?, and stray comments

* Update Icon docs page

* some fixes

* let's merge
@swrobel swrobel mentioned this pull request Aug 20, 2018
Closed
@nbkhope
Copy link

nbkhope commented Sep 6, 2018 •
edited
Loading

@mbrookes Why was FileDownload icon removed from the icons package? We wouldn't want to include @material-ui/docs in our projects just to get that icon. Is there an identical icon but with a different name in the /icons package?

@mbrookes
Copy link
Member Author

mbrookes commented Sep 7, 2018

Why was FileDownload icon removed from the icons package?

Ask google! 😆

We wouldn't want to include @material-ui/docs in our projects just to get that icon.

It would add exactly the same amount of code as if that icon existed in the icons package, but you could always copy it locally.

Is there an identical icon but with a different name in the /icons package?

Here's what's included: https://material.io/tools/icons/?style=baseline

@snyk-bot snyk-bot mentioned this pull request Sep 30, 2019
Open
This was referenced Mar 26, 2020
Merged
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliviertassinari oliviertassinari oliviertassinari approved these changes

Assignees
No one assigned
Labels
breaking change component: Icon The React component. new feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mbrookes @oliviertassinari @nbkhope