Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Doc] Update <NumberInput> docs to match new behavior #9184

Closed
itspladd opened this issue Aug 14, 2023 · 1 comment · Fixed by #9186
Closed

[Doc] Update <NumberInput> docs to match new behavior #9184

itspladd opened this issue Aug 14, 2023 · 1 comment · Fixed by #9186
Assignees

Comments

@itspladd
Copy link

itspladd commented Aug 14, 2023

Is your feature request related to a problem? Please describe.
The <NumberInput> documentation still references the component's old behavior, in which it only updates on blur. The component was changed in PR #8033; more specifically, the component now functions well in a filter form, since it updates the filtered value on change instead of on blur.

Describe the solution you'd like
Update the <NumberInput> docs to reflect the new behavior and remove or update the "Usage In Filter Form" section.

Describe alternatives you've considered
N/A, I think

Additional context
I'm not sure if there are still caveats or special considerations for using <NumberInput> in a filter form; otherwise, I'd just submit a PR to update the docs directly. However, I can anecdotally say that I've used it to filter lists by Postgres ID with no customization or obvious problems.

@fzaninotto
Copy link
Member

Good catch, thanks for pointing that out!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants