Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs tutorial - cosmetic issue - URLField link does not point to the right URL #9592

Closed
siraj-samsudeen opened this issue Jan 18, 2024 · 2 comments · Fixed by #9604
Closed
Assignees

Comments

@siraj-samsudeen
Copy link

This is my day 2 with react-admin - really appreciate the clear yet comprehensive and friendly tutorial and how readable the code is, compared to barebones React and Refine. In the spirit of the improving something already excellent, here is a cosmetic issue to fix:

We have a bunch of URLs displayed in the Users list - the first one points to http://localhost:5173/demarco.info - I believe this is happening because it is interpreted as a relative URL. I tried to add the prefix http:// in the custom MyUrlField component and it fixed the problem. If you accept this as an issue, I can send a PR with that modification.

@fzaninotto
Copy link
Member

Hi,

really appreciate the clear yet comprehensive and friendly tutorial and how readable the code is,

Thanks! We really appreciate the feedback.

You're right, the custom MyUrlField needs a http in front of the src. We'll gladly accept a fix on the Getting Started tutorial and in the examples/tutorial/src/MyUrlField file.

@siraj-samsudeen
Copy link
Author

Sorry Francois. I could not send the PR in time, and thanks for taking it up and closing it promptly. Really appreciate the diligence.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants