Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ra-jsonapi-client to third-party Data Providers #2386

Merged
merged 2 commits into from
Oct 3, 2018
Merged

Add ra-jsonapi-client to third-party Data Providers #2386

merged 2 commits into from
Oct 3, 2018

Conversation

henvo
Copy link
Contributor

@henvo henvo commented Oct 3, 2018

Hey!

First of all: Awesome project.

I needed a data provider for my JSONAPI backend and first tried this client:
moonlight-labs/aor-jsonapi-client

Unfortunately this project is deprecated and does not seem to be maintained anymore.
It was already marked as deprecated with this pull request a couple of days ago:
#2300

So I've written my own:
henvo/ra-jsonapi-client

The client is now in a reasonably stable state and I would like to submit this to the third-party data providers.

Let me know what you think and have a great day.

This PR ships a new JSONAPI client for React Admin.
It aims at replacing the deprecated `aor-jsonapi-client` data provider.
Copy link
Collaborator

@djhi djhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Would you mind removing the old one from the Legacy Data Providers section too ?

@henvo
Copy link
Contributor Author

henvo commented Oct 3, 2018

@djhi removed the old one.

Copy link
Collaborator

@djhi djhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@djhi djhi merged commit 58f5597 into marmelab:master Oct 3, 2018
@fzaninotto fzaninotto modified the milestones: 2.3.3, 2.3.4 Oct 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants