Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'icon' prop to buttons #2556

Merged
merged 2 commits into from
Nov 27, 2018
Merged

Add 'icon' prop to buttons #2556

merged 2 commits into from
Nov 27, 2018

Conversation

afilp
Copy link
Contributor

@afilp afilp commented Nov 22, 2018

We had the need to customize the icon shown on the ShowButton.

This commit changes just the ShowButton, so that you comment whether you like this change or not.

If you agree with this, let me know so that we also update the rest of the buttons located inside the button folder.

Thanks.

@fzaninotto
Copy link
Member

Love it! Would you mind going a bit further and do the same for other buttons?

@afilp
Copy link
Contributor Author

afilp commented Nov 23, 2018

Sure! That was the idea! First to see if you want it, then take the time to do the rest. I will do this most likely during the weekend.

Thanks!

@afilp
Copy link
Contributor Author

afilp commented Nov 25, 2018

Added 2nd commit for the rest of the buttons.

Please note that in some "class"-using buttons I moved the propTypes and defaultProps as static. This was done for consistency: Some classes used the static approach, others the named declaration at the end, now all of them use the same logic, the static one. If you prefer the other approach just let me know to do the opposite.

@djhi djhi added this to the 2.5.0 milestone Nov 27, 2018
@djhi
Copy link
Collaborator

djhi commented Nov 27, 2018

Thanks!

@djhi djhi merged commit 741b75b into marmelab:next Nov 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants