Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RFR] Reference many hooks #3236

Merged
merged 8 commits into from
Jun 4, 2019
Merged

[RFR] Reference many hooks #3236

merged 8 commits into from
Jun 4, 2019

Conversation

ThieryMichel
Copy link
Contributor

@ThieryMichel ThieryMichel commented May 16, 2019 •
edited
Loading

  • refactor ReferenceManyFieldCOntroller from calls component to functional component
  • use hooks to inject redux state
  • add useReferenceMany hooks
  • use referenceMany hooks
  • add doc

@Kmaschta Kmaschta changed the base branch from master to next May 16, 2019 11:30
djhi
djhi reviewed May 17, 2019
View reviewed changes
Copy link
Collaborator

@djhi djhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Promising!

@fzaninotto
Copy link
Member

what's left for RFR?

@ThieryMichel ThieryMichel force-pushed the reference_many_hooks branch 2 times, most recently from af98d09 to 09a9a26 Compare May 21, 2019 12:05
@ThieryMichel ThieryMichel force-pushed the reference_many_hooks branch from 4ad9e6f to 87002d1 Compare May 23, 2019 14:49
@ThieryMichel ThieryMichel changed the title [WIP] Reference many hooks [RFR] Reference many hooks May 23, 2019
fzaninotto
fzaninotto requested changes May 24, 2019
View reviewed changes
packages/ra-core/src/controller/usePagination.ts Outdated Show resolved Hide resolved
packages/ra-core/src/controller/useSort.ts Outdated Show resolved Hide resolved
packages/ra-ui-materialui/src/field/ReferenceManyField.js Outdated Show resolved Hide resolved
@fzaninotto fzaninotto merged commit a5ed135 into next Jun 4, 2019
@fzaninotto fzaninotto deleted the reference_many_hooks branch June 4, 2019 14:48
@fzaninotto
Copy link
Member

Thanks!

@fzaninotto fzaninotto mentioned this pull request Jun 4, 2019
Closed
40 tasks
@fzaninotto fzaninotto added this to the 3.0.0 milestone Jun 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djhi djhi djhi left review comments

@fzaninotto fzaninotto fzaninotto approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@ThieryMichel @fzaninotto @djhi