Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RFR] Add tabs prop to <TabbedForm> to allow injecting custom Tabs component #3288

Merged
merged 7 commits into from
Jun 13, 2019
Merged

[RFR] Add tabs prop to <TabbedForm> to allow injecting custom Tabs component #3288

merged 7 commits into from
Jun 13, 2019

Conversation

sagarbakhtar
Copy link
Contributor

@sagarbakhtar sagarbakhtar commented May 30, 2019 •
edited
Loading

  • New component TabbedFormTabs to be default prop 'tabs' and replace Tabs in TabbedForm
  • Test cases for a new component
  • Relevant doc changes

Fixes #3116

@sagarbakhtar sagarbakhtar changed the title [WIP] Replace Tabs in TabbedForm with new default prop 'tabs' [RFR] Replace Tabs in TabbedForm with new default prop 'tabs' May 31, 2019
djhi
djhi requested changes May 31, 2019
View reviewed changes
docs/CreateEdit.md Outdated Show resolved Hide resolved
docs/CreateEdit.md Outdated Show resolved Hide resolved
@sagarbakhtar
Copy link
Contributor Author

@djhi Thanks !!

@djhi
Copy link
Collaborator

djhi commented May 31, 2019

Thanks for working on this :) I'll wait for @fzaninotto though as this is technically a new feature and we're working on the 3.0 which includes #3246.

It means we'll probably ask you to target the next branch and to ensure the tabs prop accepts a component instead of an element.

@fzaninotto
Copy link
Member

Indeed, please rebase on next as it's a new feature.

@fzaninotto
Copy link
Member

Also, material-ui has implemented scrollable fullwidth tabs in mui/material-ui#15670

@sagarbakhtar sagarbakhtar force-pushed the scrollable-form-tabs branch from 596b727 to 162b7e3 Compare June 6, 2019 12:47
@sagarbakhtar sagarbakhtar changed the base branch from master to next June 6, 2019 12:48
@fzaninotto fzaninotto changed the title [RFR] Replace Tabs in TabbedForm with new default prop 'tabs' [RFR] Add tabs prop to <TabbedForm> to allow injecting custom Tabs component Jun 6, 2019
@fzaninotto
Copy link
Member

e2e tests seem to fail, can you take a look?

@sagarbakhtar
Copy link
Contributor Author

Yes, I will check it.

@sagarbakhtar sagarbakhtar force-pushed the scrollable-form-tabs branch from 14d9de5 to 7274291 Compare June 12, 2019 00:03
@sagarbakhtar
Copy link
Contributor Author

@fzaninotto fixed the issue.

djhi
djhi requested changes Jun 12, 2019
View reviewed changes
docs/CreateEdit.md Outdated Show resolved Hide resolved
docs/CreateEdit.md Outdated Show resolved Hide resolved
@sagarbakhtar
Update TabbedFormTabs documentation
5785d4b 
Co-Authored-By: Gildas Garcia <gildas.garcia@pm.me>
@fzaninotto fzaninotto merged commit 279ff21 into marmelab:next Jun 13, 2019
@fzaninotto
Copy link
Member

Thanks!

@fzaninotto fzaninotto mentioned this pull request Jun 13, 2019
Closed
@fzaninotto fzaninotto added this to the 3.0.0 milestone Jun 13, 2019
@djhi djhi mentioned this pull request Sep 2, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djhi djhi djhi requested changes

@fzaninotto fzaninotto fzaninotto approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@sagarbakhtar @djhi @fzaninotto