Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RFR] Replace component injection with element injection #3312

Merged
merged 16 commits into from
Jun 6, 2019
Merged

[RFR] Replace component injection with element injection #3312

merged 16 commits into from
Jun 6, 2019

Conversation

djhi
Copy link
Collaborator

@djhi djhi commented Jun 5, 2019

Revert #3262

@djhi
Copy link
Collaborator Author

djhi commented Jun 5, 2019

It's green but I still have a strange warning left to fix

fzaninotto
fzaninotto reviewed Jun 6, 2019
View reviewed changes
packages/ra-ui-materialui/src/list/List.js
@@ -1,13 +1,12 @@
/* eslint no-console: ["error", { allow: ["warn", "error"] }] */
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can this be the cause of your warning?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope, it's a warning about react-router

fzaninotto
fzaninotto approved these changes Jun 6, 2019
View reviewed changes
Copy link
Member

@fzaninotto fzaninotto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kudos for the work done already.

There were 100 files changed in the previous PR, only 91 in this PR. Some changes may be missing.

I see that you didn't update the UPGRADE guide.

@djhi
Copy link
Collaborator Author

djhi commented Jun 6, 2019

There were 100 files changed in the previous PR, only 91 in this PR. Some changes may be missing.

Yes some changes are still relevant (typos, etc.)

@djhi djhi changed the title [WIP] Replace component injection with element injection [RFR] Replace component injection with element injection Jun 6, 2019
@fzaninotto fzaninotto mentioned this pull request Jun 6, 2019
Closed
@fzaninotto fzaninotto merged commit 54cec30 into next Jun 6, 2019
@fzaninotto fzaninotto deleted the replace-component-inject-with-element-injection branch June 6, 2019 13:23
@fzaninotto
Copy link
Member

Thanks a lot!

@djhi djhi mentioned this pull request Jun 6, 2019
Merged
@fzaninotto fzaninotto added this to the 3.0.0 milestone Jun 6, 2019
@fzaninotto fzaninotto mentioned this pull request Jun 21, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fzaninotto fzaninotto fzaninotto approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@djhi @fzaninotto