Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFR] Migrate Responsive to custom media queries #3329

Merged
merged 19 commits into from
Aug 9, 2019
Merged

Conversation

fzaninotto
Copy link
Member

@fzaninotto fzaninotto commented Jun 12, 2019

  • Replace usage of <Responsive> in react-admin by media query hooks
  • Replace usage of <Responsive> in examples by media query hooks
  • Document the new hooks
  • Fix tests

This PR is blocked by a regression in material-ui, which makes the tests fail with the hooks (mui/material-ui#16184). (fixed in https://github.com/mui-org/material-ui/releases/tag/v4.1.1)

Copy link
Collaborator

@djhi djhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😍

@fzaninotto fzaninotto force-pushed the mediaQueries branch 2 times, most recently from 00736fc to fcefd61 Compare June 20, 2019 07:47
@djhi
Copy link
Collaborator

djhi commented Jul 25, 2019

Copy link
Collaborator

@djhi djhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@djhi djhi changed the title [WIP] Migrate Responsive to custom media queries [RFR] Migrate Responsive to custom media queries Aug 9, 2019
@Kmaschta Kmaschta merged commit 0a2a43e into next Aug 9, 2019
@Kmaschta Kmaschta deleted the mediaQueries branch August 9, 2019 15:23
@fzaninotto fzaninotto added this to the 3.0.0 milestone May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants