-
-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RFR] Migrate Responsive to custom media queries #3329
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djhi
reviewed
Jun 12, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😍
fzaninotto
force-pushed
the
mediaQueries
branch
2 times, most recently
from
June 20, 2019 07:47
00736fc
to
fcefd61
Compare
40 tasks
fzaninotto
force-pushed
the
mediaQueries
branch
from
August 1, 2019 09:27
94db5a2
to
0286050
Compare
djhi
approved these changes
Aug 9, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔥
djhi
changed the title
[WIP] Migrate Responsive to custom media queries
[RFR] Migrate Responsive to custom media queries
Aug 9, 2019
Kmaschta
approved these changes
Aug 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
<Responsive>
in react-admin by media query hooks<Responsive>
in examples by media query hooksThis PR is blocked by a regression in material-ui, which makes the tests fail with the hooks (mui/material-ui#16184).(fixed in https://github.com/mui-org/material-ui/releases/tag/v4.1.1)