[RFR] Refactor I18n layer to use hooks #3672
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fzaninotto
force-pushed
the
i18n-hook
branch
from
907bd21 to
9a64f32
Compare
djhi
reviewed
Sep 11, 2019
| }) | ||
| .catch(error => { | ||
| stopLoading(); | ||
| notify('ra.notification.i18n_error', 'warning'); |
There was a problem hiding this comment.
This is a technical error. I'm not sure we should notify the end user about it
There was a problem hiding this comment.
The error occurs while loading (potentially via http) a new set of messages. The problem may be on the user side (networking problem), at this stage there is no way to know.
I think it's preferable to show an error notification when the language switch fails, otherwise a user who pressed a 'change locale' button may hit the button again and again, thinking their click didn't work.
djhi
approved these changes
Sep 11, 2019
40 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TranslationProviderusing hooksuseSetLocale()anduseLocale()hooksuseLoading()anduseUpdateLoading()hooks (wrapper around the dispatching of loading actions)withTranslateis unchanged, and the i18nProvider signature stays the same. The only changes for existing apps are for getting and setting locale, and for custom apps).But the code is now much easier to follow, and more idiomatic to modern React.
Added benefit: when using a custom app, developers can replace the
TranslationProviderby their own and use another translate function than Polyglot (as long as it has the same signature) (refs #2307.