Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ability to create custom DeleteButton views without rewriting the logic #4858

Merged
merged 1 commit into from
May 27, 2020
Merged

Add ability to create custom DeleteButton views without rewriting the logic #4858

merged 1 commit into from
May 27, 2020

Conversation

fzaninotto
Copy link
Member

I wanted a DeleteIconButton, and I found myself copying the DeleteButton logic code. Better move it to ra-core.

@fzaninotto fzaninotto added the RFR Ready For Review label May 26, 2020
@djhi djhi added this to the 3.6.0 milestone May 27, 2020
@djhi djhi merged commit 48c3a66 into next May 27, 2020
@djhi djhi deleted the delete-button-hooks branch May 27, 2020 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djhi djhi djhi approved these changes

Assignees
No one assigned
Labels
RFR Ready For Review
Projects
None yet
Milestone
3.6.0
Development

Successfully merging this pull request may close these issues.
2 participants
@fzaninotto @djhi