Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.x.x] Add disabled option in SelectArrayInput #4882

Closed
wants to merge 1 commit into from
Closed

[2.x.x] Add disabled option in SelectArrayInput #4882

wants to merge 1 commit into from

Conversation

maxmalov
Copy link

@maxmalov maxmalov commented Jun 1, 2020

This is mostly backporting of #2555 but for SelectArrayInput. Currently, we stuck at version 2.9.9, that's why I've picked branch 2.x.x as the base branch.

If these changes are ok and good to go, I would like to "forwardport" them to the latest version a little bit later 😉

"eslint-plugin-react-hooks": "^1.6.0",
"express": "~4.16.3",
"full-icu": "~1.2.1",
"husky": "^2.3.0",
"jest": "^23.6.0",
"jest-dom": "3.5.0",
Copy link
Author

@maxmalov maxmalov Jun 1, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no other idea how to test whether a dom element (for menu item) is disabled. I've picked the old version with the purpose to have the smallest set of changes inside yarn.lock

@fzaninotto
Copy link
Member

Hi, and thanks for your contribution.

Version 2 is in maintenance mode, so we won't be adding new features to it. If you need enhancements on that version, I suggest you fork it and republish it under another organization.

To add new features, please use the next branch (currently based on version 3).

@fzaninotto fzaninotto closed this Jun 2, 2020
@alextaymx
Copy link

hi , do we still have disabled options in select array input?

@Mwamitovi
Copy link

Same issue here, adding "disabled: true" doesn't seem to disable a fields within <SelectArrayInput>.
Any alternatives?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants