Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

De-googleify e-commerce demo #4948

Merged
merged 6 commits into from
Jun 17, 2020
Merged

De-googleify e-commerce demo #4948

merged 6 commits into from
Jun 17, 2020

Conversation

fzaninotto
Copy link
Member

Problem

With the default material-ui theme, the demo looks too much like a Google, and turns some people away.

Solution

Customize the theme for the demo.

before

127 0 0 1_3000_ (1)

after

127 0 0 1_3000_

@fzaninotto fzaninotto added the RFR Ready For Review label Jun 17, 2020
Copy link
Collaborator

@djhi djhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should use the theme.spacing() function when dealing with padding and margin. It would ensure consistency

@fzaninotto
Copy link
Member Author

The dark theme hasn't changed much but it's still usable.

127 0 0 1_3000_ (2)

@fzaninotto
Copy link
Member Author

As for using theme spacing, you're right in theory, but:

  1. we currently don't give a way to customize the default theme spacing in the demo, so it's useless
  2. There are MANY other components in this demo using numbers for spacing. This would be a day of work.

@djhi djhi merged commit a945a14 into next Jun 17, 2020
@djhi djhi deleted the example-demo-ui branch June 17, 2020 12:06
@fzaninotto fzaninotto added this to the 3.7.0 milestone Jun 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
RFR Ready For Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants