Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use latest react-transition-group #5079

Merged
merged 1 commit into from
Jul 29, 2020
Merged

Use latest react-transition-group #5079

merged 1 commit into from
Jul 29, 2020

Conversation

pietro909
Copy link
Contributor

Luwangel
Luwangel suggested changes Jul 24, 2020
View reviewed changes
Copy link
Contributor

@Luwangel Luwangel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thanks for contributing. You should run make install in order to upgrade the yarn.lock. See Yarn documentation.

@pietro909
Copy link
Contributor Author

Thank you, I've updated it @Luwangel

Curious enough, the diff shows that it was already in the yarn.lock.

@pietro909 pietro909 requested a review from Luwangel July 25, 2020 08:51
Luwangel
Luwangel suggested changes Jul 27, 2020
View reviewed changes
Copy link
Contributor

@Luwangel Luwangel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ran yarn why react-transition-group to better understand and the package comes from material-ui.

In order to merge this PR, please do:

  1. Update the dependency version to v4.4.1
  2. Run make install

And we'll be good 👍 Thank you again :)

@pietro909
Copy link
Contributor Author

Updated. Thank you for your instructions, I hope is ok now :-)

@Luwangel Luwangel added this to the 3.8.0 milestone Jul 29, 2020
@Luwangel Luwangel merged commit 1a78cfb into marmelab:master Jul 29, 2020
@Luwangel Luwangel added enhancement RFR Ready For Review and removed enhancement labels Jul 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Luwangel Luwangel Luwangel approved these changes

Assignees
No one assigned
Labels
RFR Ready For Review
Projects
None yet
Milestone
3.8.0
Development

Successfully merging this pull request may close these issues.

Deprecated findDOMNode warning in StrictMode
2 participants
@pietro909 @Luwangel