Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DOC] Fix markdown of props tables. #5150

Merged
merged 2 commits into from
Aug 13, 2020
Merged

[DOC] Fix markdown of props tables. #5150

merged 2 commits into from
Aug 13, 2020

Conversation

WiXSL
Copy link
Contributor

@WiXSL WiXSL commented Aug 12, 2020

No description provided.

@WiXSL WiXSL changed the title Fix markdown of props tables. [DOC] Fix markdown of props tables. Aug 12, 2020
djhi
djhi approved these changes Aug 13, 2020
View reviewed changes
Copy link
Collaborator

@djhi djhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@djhi djhi added this to the 3.8.2 milestone Aug 13, 2020
@djhi
Copy link
Collaborator

djhi commented Aug 13, 2020

When trying to run the documentation locally with Jekyll 3.8.6, I had many issues, not related to your changes. I took the opportunity to fix them :)

@fzaninotto fzaninotto merged commit e1fb8e6 into marmelab:master Aug 13, 2020
@fzaninotto
Copy link
Member

Thanks!

@WiXSL WiXSL deleted the fix-props-tables branch August 13, 2020 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djhi djhi djhi approved these changes

@fzaninotto fzaninotto fzaninotto approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.8.2
Development

Successfully merging this pull request may close these issues.
3 participants
@WiXSL @djhi @fzaninotto