Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add onSuccess Callback Infos about undoable prop #5260

Merged
merged 4 commits into from
Sep 18, 2020
Merged

Add onSuccess Callback Infos about undoable prop #5260

merged 4 commits into from
Sep 18, 2020

Conversation

jdemangeon
Copy link
Contributor

@jdemangeon jdemangeon commented Sep 16, 2020 •
edited by Luwangel
Loading

Fixes #5195

@jdemangeon jdemangeon added the RFR Ready For Review label Sep 16, 2020
@jdemangeon jdemangeon added this to the 3.8.5 milestone Sep 16, 2020
@jdemangeon jdemangeon mentioned this pull request Sep 16, 2020
Closed
@jdemangeon jdemangeon linked an issue Sep 16, 2020 that may be closed by this pull request
onSuccess Prop on Edit Component not working as intended #5195
Closed
djhi
djhi requested changes Sep 16, 2020
View reviewed changes
docs/CreateEdit.md Outdated Show resolved Hide resolved
docs/CreateEdit.md Outdated Show resolved Hide resolved
jdemangeon and others added 2 commits September 16, 2020 16:58
@jdemangeon @djhi
Update docs/CreateEdit.md
e843325 
Co-authored-by: Gildas Garcia <1122076+djhi@users.noreply.github.com>
@jdemangeon @djhi
Update docs/CreateEdit.md
72b3b97 
Co-authored-by: Gildas Garcia <1122076+djhi@users.noreply.github.com>
@jdemangeon
Copy link
Contributor Author

@djhi review applied 👍

djhi
djhi requested changes Sep 16, 2020
View reviewed changes
docs/CreateEdit.md Outdated Show resolved Hide resolved
@jdemangeon @djhi
Update docs/CreateEdit.md
9eeda3b 
Co-authored-by: Gildas Garcia <1122076+djhi@users.noreply.github.com>
@jdemangeon
Copy link
Contributor Author

Review applied again

@Luwangel Luwangel merged commit 669f415 into master Sep 18, 2020
@Luwangel Luwangel deleted the add-onsuccess-callback-informations branch September 18, 2020 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djhi djhi djhi approved these changes

@fzaninotto fzaninotto Awaiting requested review from fzaninotto

Assignees
No one assigned
Labels
RFR Ready For Review
Projects
None yet
Milestone
3.8.5
Development

Successfully merging this pull request may close these issues.

onSuccess Prop on Edit Component not working as intended
3 participants
@jdemangeon @djhi @Luwangel