Fix unexpected List Page Change #5263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fzaninotto
reviewed
Sep 16, 2020
|
Can you please add a description? It seems this solves 2 different bugs |
|
Review applied |
jdemangeon
force-pushed
the
fix-unexpected-list-controller-page-change
branch
from
d9b7dfa
to
09013a2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix avoid resetting current page (in a list) when the total is resetted (during loading phase).
This way, the demo "reviews" page don't go to the first page when we accept or reject a review.
I also removed the redirect to "/reviews" when we accept or reject reviews in bulk mode. This way we stay on the current page of reviews
Closes #5168
Closes #5185