Introduce RecordContext and Base components for Edit, Create and Show #5422
Conversation
djhi
changed the title
| title, | ||
| version, | ||
| ...rest | ||
| } = props; |
There was a problem hiding this comment.
CreateView should use the CreateContext to get the controller props. See how I did in ListView
| undoable, | ||
| version, | ||
| ...rest | ||
| } = props; |
There was a problem hiding this comment.
should use useEditContext to get controller props
| title, | ||
| version, | ||
| ...rest | ||
| } = props; |
There was a problem hiding this comment.
grab the show controller props from useShowContext
| import { Record } from '../types'; | ||
|
|
||
| /** | ||
| * Context to store the result of the useRecord() hook. |
There was a problem hiding this comment.
| * Context to store the result of the useRecord() hook. | |
| * Context to store the current record. |
| /** | ||
| * Context to store the result of the useRecord() hook. | ||
| * | ||
| * Use the useRecordContext() hook to read the context. That's what the Edit and Show components do in react-admn. |
There was a problem hiding this comment.
| * Use the useRecordContext() hook to read the context. That's what the Edit and Show components do in react-admn. | |
| * Use the useRecordContext() hook to read the context. That's what the Edit and Show components do in react-admin. |
| * import { useEditController, EditContext } from 'ra-core'; | ||
| * | ||
| * const Edit = props => { | ||
| * const controllerProps = useEditController(props); |
There was a problem hiding this comment.
bad code example. Shouldn't it be:
const { record }= useEditController(props);
return (
<RecordContextProvider value={record}>
...
</RecordContextProvider>
);
??
| }; | ||
|
|
||
| /** | ||
| * Hook to read the record from a context which provide one, such as the EditContext or ShowContext. |
There was a problem hiding this comment.
| * Hook to read the record from a context which provide one, such as the EditContext or ShowContext. | |
| * Hook to read the record from a RecordContext. |
| >( | ||
| context: RecordType | ||
| ) => { | ||
| return pick(context, ['record']); |
There was a problem hiding this comment.
I'm thinking: every time something changes in a context (e.g. the selected ids in the list), the pick command will return a new instance of the record, re-rendering everything.
I think it's not a premature optimization to memoize the picking.
| */ | ||
| export const useRecordContext = < | ||
| RecordType extends Record | Omit<Record, 'id'> = Record | ||
| >() => { |
There was a problem hiding this comment.
you must expect a record to be passed here to allow backwards compatibility
| * saving | ||
| * } = useSaveContext(); | ||
| */ | ||
| export const useSaveContext = () => { |
There was a problem hiding this comment.
must accept props as params for BC
| export const useSaveContext = () => { | ||
| const context = useContext(SaveContext); | ||
|
|
||
| if (!context) { |
There was a problem hiding this comment.
this will never happen: the default context is an object
Co-authored-by: Adrien Amoros <adrien.amoros@gmail.com>
|
I'm so happy to have this merged! |
No description provided.