Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Appbar custom content flickers when loading #5434

Merged
merged 3 commits into from
Oct 23, 2020
Merged

Fix Appbar custom content flickers when loading #5434

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
342c258
Fix Appbar custom content flickers when loading
fzaninotto Oct 22, 2020
ca690d8
Review
fzaninotto Oct 22, 2020
a87bb03
review
fzaninotto Oct 22, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions packages/ra-ui-materialui/src/layout/LoadingIndicator.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,12 +9,12 @@ import { useRefreshWhenVisible } from 'ra-core';
import RefreshIconButton from '../button/RefreshIconButton';

const useStyles = makeStyles(
{
theme => ({
loader: {
margin: 14,
margin: theme.spacing(2),
},
loadedIcon: {},
},
}),
{ name: 'RaLoadingIndicator' }
);

Expand All @@ -27,8 +27,8 @@ const LoadingIndicator = props => {
<CircularProgress
className={classNames('app-loader', classes.loader, className)}
color="inherit"
size={18}
thickness={5}
size="1em"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You might want to get the theme from useTheme and apply the same spacing

thickness={6}
{...rest}
/>
) : (
Expand Down