Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add default value for hasShow in Show.tsx #5471

Merged
merged 1 commit into from
Nov 2, 2020

Conversation

FredericEspiau
Copy link
Contributor

Prevents having hasShow on a div element, because React complains about this

Warning: React does not recognize the `hasShow` prop on a DOM element. If you intentionally want it to appear in the DOM as a custom attribute, spell it as lowercase `hasshow` instead. If you accidentally passed it from a parent component, remove it from the DOM element.
    in div (created by ShowView)
    in ShowView (created by Show)

Prevents having `hasShow` on a `div` element, because `React` complains about this

```
Warning: React does not recognize the `hasShow` prop on a DOM element. If you intentionally want it to appear in the DOM as a custom attribute, spell it as lowercase `hasshow` instead. If you accidentally passed it from a parent component, remove it from the DOM element.
    in div (created by ShowView)
    in ShowView (created by Show)
```
@djhi djhi added this to the 3.9.6 milestone Nov 2, 2020
@djhi
Copy link
Collaborator

djhi commented Nov 2, 2020

Thanks!

@djhi djhi merged commit d1d6e22 into marmelab:master Nov 2, 2020
@FredericEspiau FredericEspiau deleted the patch-1 branch November 2, 2020 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants